Move NotificationCenter to swift-foundation #5246
Merged
+42
−95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
NotificationCenterintoswift-foundation.NotificationCenteris now defined inswift-foundation, with some methods kept inswift-corelibs-foundationviaextension. This has the result of removing the ability to override these methods, e.g.addObserver(forName:object:queue:block)cannot beopenin anextension.NotificationCenterno longer conforms toNSObjectinswift-corelibs-foundationdue to the lack ofNSObjectinswift-foundation, whereNotificationCenteris now defined, and the inability to add that inheritance retroactively inswift-corelibs-foundation.NotificationCenterwas moved toswift-foundationand is accessed via@_spi(SwiftCorelibsFoundation) publicmethods. This enables methods likeaddObserver(forName:object:queue:block)to remain inswift-corelibs-foundation.